Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929

Merged
merged 4 commits into from
Jul 20, 2023
Merged

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929

merged 4 commits into from
Jul 20, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 20, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Closed
AlexWaygood
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unnecessary use of quoted annotations now that we have from __future__ import annotations at the top of the file:

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
erlend-aasland and others added 2 commits July 20, 2023 22:52
@erlend-aasland @AlexWaygood
Apply suggestions from code review
a13d26b 
Extra quotes around Parameter are not needed anymore

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland
Apply suggestions from code review
4fa647e 
Rip out ParamIter
AlexWaygood
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Tools/clinic/clinic.py
@@ -1415,6 +1419,7 @@ def render_option_group_parsing(self, f, template_dict):
group = required
else:
right.append(group)
assert group is not None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but I feel like there's probably a simpler way of writing the code immediately above that would be easier to understand and not require this assertion here for mypy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should accumulate these smells in the modernising-issue, so we don't forget. Or we can just grep for asserts.

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland @AlexWaygood
🤦
5fe6c3f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland
Copy link
Contributor Author

LGTM, thanks!

Thanks, the same!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 20, 2023 21:13
@erlend-aasland erlend-aasland merged commit 42c6300 into python:main Jul 20, 2023
18 checks passed
@erlend-aasland erlend-aasland deleted the clinic/annotate-clanguage-render-option-group-parsing branch July 20, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot